One Hour One Life Forums

First time posting here.

I recently bought the game on steam after hearing about it and absolutely loved it.
However I quickly began to notice a couple issues with it.

First, the VSync is always on no matter what you do even though there seems to be a "countingOnVSync" setting for it which also seems to show up in the menu.

Second, sometimes when there is a lot going on in the screen, the game will go in a "slow motion" sort of lag where everything including the hud and the pause menu itself takes twice as long to move/update.
This makes it incredibly difficult to move or do anything really.

This to me strongly suggested that the game was dependent on the framerate for timing purposes.
So a couple days ago I decided to go digging around in the code since it was open source.
What I found was the explanation for everything and also a couple of odd things.
To start with, there indeed was code to handle VSync that could be turned off here (from ScreenGL_SDL.cpp, minorGems):

Yet the VSync was still on regardless of the setting that controls mUseFrameSleep.
So I moved on to another idea and found this (from the same file):

Admittedly I didn't bother to try and remove the flag to see if it would turn off the VSync but I suspect this is the reason as to why it is always on no matter what.

Next I checked LivingLifePage.cpp from OneLife and found out that the game was indeed dependent on the framerate for timing purposes.
The game code relies on a variable called frameRateFactor but never updates it as if it was made on the assumption that the framerate would always be absolutely constant no matter what.
So I fixed it and also changed the parts of the code that seemed to assume frameRateFactor would always be constant with 2 commits here and here.
Now whenever the framerate drops the game runs perfectly without slow motion.
On that note, this game does have framerate issues that hopefully could be addressed in the future.

All in all I was kind of confused by this, what was jason's intention while writing this code?
Is VSync intended to be always on no matter what, despite what the setting and some parts of the code seem to suggest?
I also found this function while looking through the code:

which seems to indicate that the problem is known yet the function is called nowhere as far as I can tell and after trying to use it it turned out to be buggy as the animations would not loop properly.
If you ask me, I'm fine with VSync being on as a default but I think people should always have the choice to turn it off and let the game run as fast as it can on their machine or possibly set their own FPS cap.

Another thing I wanted to talk about was the structure of the game code itself.
I get that this is purely a multiplayer game and that it's not supposed to work without a server, but absolutely everything seems to be done at the same time.
Reading server messages, physics/logic code, rendering. All at once.
Particularly in LivingLifePage::step(). This method is an absolute monster, roughly 5k in lines.
Why not split/organize the code into multiple functions here? Possibly even like what most game engines do: network parsing, logic/physics followed by rendering.
I'm not trying to argue against anything here, I'm simply curious about all this as I'm only familiar with the usual way game engines are made.

Anyways, I'm not sure if it's alright to post binaries here, hopefully someone can inform me.
The fix works great, it's helped me a ton as I often do get FPS lag in big towns.
I'm not sure how common this issue is, I've heard other people ingame saying they experience it.
I should also mention that I have a 144hz screen, perhaps people who have 60hz monitors run into the issue much less often, I don't know.